state.code and country.code aren't nil-safe
Reported by Marnen Laibow-Koser | October 13th, 2009 @ 01:35 PM
User#state.code and User#state.country.code aren't nil-safe, so the app crashes if the state or country is blank.
Comments and changes to this ticket
-
Marnen Laibow-Koser October 19th, 2009 @ 04:54 PM
- State changed from “new” to “open”
Working on this.
-
Marnen Laibow-Koser October 19th, 2009 @ 04:57 PM
Since User (and Event!) is composed_of Address, this will probably be easiest to attack if we take care of this in Address, then make User#state and Event#state delegate to Address#state.
-
Marnen Laibow-Koser October 19th, 2009 @ 07:16 PM
Almost working. But we need to unify the handling of coordinates in User and Event.
-
Marnen Laibow-Koser October 19th, 2009 @ 07:18 PM
- State changed from “open” to “hold”
Created a ticket (#43) for coords handling. Putting this ticket on hold till we deal with #43.
-
Marnen Laibow-Koser October 19th, 2009 @ 09:08 PM
- State changed from “hold” to “open”
Reopening now that #43 is done.
-
Marnen Laibow-Koser October 20th, 2009 @ 11:19 AM
(from [dcf5d67a5b69e33648edebb7655486732f39f9d1]) Introduce QuietNil class for when we really don't care about chained methods. [#41] http://github.com/marnen/quorum2/commit/dcf5d67a5b69e33648edebb7655...
-
Marnen Laibow-Koser October 20th, 2009 @ 11:19 AM
(from [edd1bc71ffa9a92334e58983064b5d5a48302d84]) Start trying to use QuietNils. Not working yet. [#41] http://github.com/marnen/quorum2/commit/edd1bc71ffa9a92334e58983064...
-
Marnen Laibow-Koser October 20th, 2009 @ 11:19 AM
(from [d25469aa06bf6798572b76df140b1404a6fd218b]) Make User#state mass-assignable. Can we maybe just remove the attr_accessible? [#41] http://github.com/marnen/quorum2/commit/d25469aa06bf6798572b76df140...
-
-
Marnen Laibow-Koser October 20th, 2009 @ 11:19 AM
(from [8f779577950f68fb07b851cfb1fa2477416ace18]) Introduce AddressUtilities for common address functionality. [#41] http://github.com/marnen/quorum2/commit/8f779577950f68fb07b851cfb1f...
-
Marnen Laibow-Koser October 20th, 2009 @ 11:19 AM
(from [f82d0eec52515f79d7e5fdbc7c450ece29745ed4]) Refactor composed_of into AddressUtilities. [#41] http://github.com/marnen/quorum2/commit/f82d0eec52515f79d7e5fdbc7c4...
-
Marnen Laibow-Koser October 20th, 2009 @ 11:19 AM
(from [b4cfd43d84c272a30bdc6a0332245cc1253b784c]) Add a spec to make sure we're nil-safe. [#41] http://github.com/marnen/quorum2/commit/b4cfd43d84c272a30bdc6a03322...
-
Marnen Laibow-Koser October 20th, 2009 @ 11:19 AM
(from [ba0b6129a5b56b00f8f074ef76d3905fdecfc912]) Make sure User#country and Event#country are nil-safe. [#41] http://github.com/marnen/quorum2/commit/ba0b6129a5b56b00f8f074ef76d...
-
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
<p>This is the issue tracker for the Quorum calendar system. Also see our <a href="http://github.com/marnen/quorum2">Github repository</a> and our <a href="http://quorum2.sourceforge.net">project website</a>.</p>
<p>Please tag bug reports with <strong>bug</strong> and feature requests with <strong>feature</strong>. Use additional descriptive tags as necessary.</p>
People watching this ticket
Marnen Laibow-Koser
Referenced by
-
42
state.code and country.code aren't nil-safe
Duplicate of #41.
-
41
state.code and country.code aren't nil-safe
(from [dcf5d67a5b69e33648edebb7655486732f39f9d1])
Introdu...
-
41
state.code and country.code aren't nil-safe
(from [edd1bc71ffa9a92334e58983064b5d5a48302d84])
Start t...
-
41
state.code and country.code aren't nil-safe
(from [d25469aa06bf6798572b76df140b1404a6fd218b])
Make Us...
-
41
state.code and country.code aren't nil-safe
(from [c12f71d44d0c18c96ba1affd0958164975c884eb])
Fix bro...
-
41
state.code and country.code aren't nil-safe
(from [8f779577950f68fb07b851cfb1fa2477416ace18])
Introdu...
-
41
state.code and country.code aren't nil-safe
(from [f82d0eec52515f79d7e5fdbc7c450ece29745ed4])
Refacto...
-
41
state.code and country.code aren't nil-safe
(from [b4cfd43d84c272a30bdc6a0332245cc1253b784c])
Add a s...
-
41
state.code and country.code aren't nil-safe
(from [ba0b6129a5b56b00f8f074ef76d3905fdecfc912])
Make su...