Make JavaScript on map page unobtrusive
Reported by Marnen Laibow-Koser | December 4th, 2008 @ 05:33 PM
JavaScript on /events/:id/map is embedded in the HTML -- it should be in an external file.
Comments and changes to this ticket
-
Marnen Laibow-Koser December 4th, 2008 @ 06:13 PM
- State changed from “new” to “open”
Looking at this.
-
Marnen Laibow-Koser December 4th, 2008 @ 06:19 PM
[Notes for my own reference later.]
It seems that the problem is in events_helper (and in YM4R): event_map generates dynamic JavaScript, all right, but then embeds it right into the HTML. What's the best way of putting the output into an extra file? Should we have a dynamic RJS or .js.erb script, or simply have a static script that reads dynamic inputs from hidden DOM elements? I'm leaning toward the latter approach at the moment, but I need to do more research.
-
Marnen Laibow-Koser December 10th, 2008 @ 12:49 AM
(from [f0897fc791e5f4181c4064cdff76f6cc0b6a2f9c]) Wrap event information in a div so we can address it later. [#3] http://github.com/marnen/quorum2...
-
Marnen Laibow-Koser December 10th, 2008 @ 12:49 AM
(from [bc6367ad82cac67a7cc0adc09fe1cf39b21ae0b0]) Remove map info window content from JavaScript by passing it as a DOM element. [#3] http://github.com/marnen/quorum2...
-
Marnen Laibow-Koser December 10th, 2008 @ 12:49 AM
(from [619dcce03c79ffa08978e39488dee4e6e3726101]) Put latitude and longitude into DOM. [#3] http://github.com/marnen/quorum2...
-
Marnen Laibow-Koser December 10th, 2008 @ 12:49 AM
(from [e00c149449334c5b15c08616856627e494b6c328]) Move JavaScript for map into separate file. [#3] http://github.com/marnen/quorum2...
-
Marnen Laibow-Koser December 10th, 2008 @ 01:03 PM
- State changed from “open” to “resolved”
This is done now, and incorporated into beta 2.8.2.
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
<p>This is the issue tracker for the Quorum calendar system. Also see our <a href="http://github.com/marnen/quorum2">Github repository</a> and our <a href="http://quorum2.sourceforge.net">project website</a>.</p>
<p>Please tag bug reports with <strong>bug</strong> and feature requests with <strong>feature</strong>. Use additional descriptive tags as necessary.</p>
People watching this ticket
Marnen Laibow-Koser
Tags
Referenced by
-
3
Make JavaScript on map page unobtrusive
(from [f0897fc791e5f4181c4064cdff76f6cc0b6a2f9c]) Wrap ev...
-
3
Make JavaScript on map page unobtrusive
(from [bc6367ad82cac67a7cc0adc09fe1cf39b21ae0b0]) Remove ...
-
3
Make JavaScript on map page unobtrusive
(from [619dcce03c79ffa08978e39488dee4e6e3726101]) Put lat...
-
3
Make JavaScript on map page unobtrusive
(from [e00c149449334c5b15c08616856627e494b6c328]) Move
Ja...