Refactor comment and attendance code
Reported by Marnen Laibow-Koser | March 8th, 2012 @ 01:09 PM | in v0.5.0 (closed)
The comment code introduced in #69 works, but does terrible things like breaking MVC. It's time to refactor how the attendance display code works.
Comments and changes to this ticket
-
Marnen Laibow-Koser March 8th, 2012 @ 01:38 PM
- State changed from “new” to “open”
- Milestone set to “v0.5.0”
- Milestone order changed from “177210” to “0”
Working on this.
-
-
Marnen Laibow-Koser March 12th, 2012 @ 12:56 PM
(from [134347e832207ff3453ed314b6c53f41be7df949]) Eager-load commitment and user data, and start manipulating them in memory. [#70] https://github.com/marnen/quorum2/commit/134347e832207ff3453ed314b6...
-
-
Marnen Laibow-Koser March 12th, 2012 @ 12:56 PM
(from [03d73e2225cd673c9c8b5574825b7c179c5c874e]) Use let instead of before block. [#70] https://github.com/marnen/quorum2/commit/03d73e2225cd673c9c8b557482...
-
Marnen Laibow-Koser March 12th, 2012 @ 12:56 PM
(from [5d6d31f02cb8a282ee05c0062f35d1c267e51d20]) Use better string concatenation syntax. [#70] https://github.com/marnen/quorum2/commit/5d6d31f02cb8a282ee05c0062f...
-
Marnen Laibow-Koser March 12th, 2012 @ 12:56 PM
(from [75c7ee9abb4e71dbba2b3e0eb95b6331f101cde0]) Reimplement helper so as not to do DB access. [#70] https://github.com/marnen/quorum2/commit/75c7ee9abb4e71dbba2b3e0eb9...
-
Marnen Laibow-Koser March 12th, 2012 @ 12:56 PM
(from [a67f03d518fde3bcf39ef231ae1380e5b1155011]) Don't make a separate query for find_committed. [#70] https://github.com/marnen/quorum2/commit/a67f03d518fde3bcf39ef231ae...
-
Marnen Laibow-Koser March 12th, 2012 @ 12:56 PM
(from [34b2f3b831046744a54f4a8a9aa4bcafe9fd980c]) Remove comment that's now inaccurate. [#70] https://github.com/marnen/quorum2/commit/34b2f3b831046744a54f4a8a9a...
-
-
-
Marnen Laibow-Koser March 12th, 2012 @ 12:56 PM
(from [5f14c7269bf0dde0071e39bb1027981e19a2ab48]) Remove scopes that we no longer need. [#70] https://github.com/marnen/quorum2/commit/5f14c7269bf0dde0071e39bb10...
-
-
Marnen Laibow-Koser March 12th, 2012 @ 12:56 PM
(from [ac5d803b6c15b29392f4a38b1c476a82e4d0e00a]) Remove FormBuilder since we're not using it. [#70] https://github.com/marnen/quorum2/commit/ac5d803b6c15b29392f4a38b1c...
-
Marnen Laibow-Koser March 12th, 2012 @ 01:11 PM
(from [12cb19d0e4a377de4e7e9a52ae3769dd79a8980a]) We can just use the comparator that we already defined in User. [#70] https://github.com/marnen/quorum2/commit/12cb19d0e4a377de4e7e9a52ae...
-
Marnen Laibow-Koser March 12th, 2012 @ 01:11 PM
(from [69f7f3441186f7331083b76783541728a2a00faa]) Fix comment rendering (and commit neglected file!). [#70] https://github.com/marnen/quorum2/commit/69f7f3441186f7331083b76783...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
<p>This is the issue tracker for the Quorum calendar system. Also see our <a href="http://github.com/marnen/quorum2">Github repository</a> and our <a href="http://quorum2.sourceforge.net">project website</a>.</p>
<p>Please tag bug reports with <strong>bug</strong> and feature requests with <strong>feature</strong>. Use additional descriptive tags as necessary.</p>
People watching this ticket
Marnen Laibow-Koser
Tags
Referenced by
-
69
Allow users to add comments to events
This technically works, and will be incorporated in versi...